Roland Illig wrote:
> Quentin Garnier wrote:
> 
>> PKGREVISION= #empty is bad because ... ?  It explicitely states
>> the variable is left empty, so there is no chance it is a typo or
>> something.
> 
> 
> What is the point of defining this variable to #empty if that definition 
> does not change anything? Isn't that like defining 
> WRKSRC=${WRKDIR}/${DISTNAME}?
> 
> Maybe there's some hidden message in saying PKGREVISION=#empty that 
> didn't reach me yet. If so, please tell me. Currently I think it is not 
> necessary and it just makes the Makefiles longer than necessary.

The special-handling of PKGREVISION was originally added by <hubertf> at 
my request.  It broke one of the complex packages that I was maintaining 
because I was using PKGREVISION partly for documentation purposes, as in 
"this is where PKGREVISION should be set", and I had set 
PKGREVISION=#empty in that package's Makefile.  I had expected it to 
work, but it didn't.

	Cheers,

	-- Johnny Lam <jlam@pkgsrc.org>