Subject: Re: Building NTOP 3.1 fails
To: Gilles Gravier <Gilles@Gravier.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: tech-pkg
Date: 10/11/2005 17:08:10
On Tue, 11 Oct 2005, Jeremy C. Reed wrote:

> There is a PR  #29525
> http://www.NetBSD.org/cgi-bin/query-pr-single.pl?number=29525
> But no discussion since February.
>
> I will look at this. I am getting another problem (but similar) first due to 
> missing libiconv.la.

I found the problem in libgdome.la. ntop depends on gdome2.

But textproc/gdome2 uses libtool but does not use USE_LIBTOOL=YES.

I have carbon-copied the maintainer.

Here is the patch for gdome:

Index: textproc/gdome2/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/gdome2/Makefile,v
retrieving revision 1.3
diff -b -u -r1.3 Makefile
--- textproc/gdome2/Makefile	25 May 2005 09:27:39 -0000	1.3
+++ textproc/gdome2/Makefile	12 Oct 2005 00:05:19 -0000
@@ -1,6 +1,7 @@
  # $NetBSD: Makefile,v 1.3 2005/05/25 09:27:39 adam Exp $

  DISTNAME=	gdome2-0.8.1
+PKGREVISION=	1
  CATEGORIES=	games
  MASTER_SITES=	http://gdome2.cs.unibo.it/tarball/

@@ -10,6 +11,7 @@

  GNU_CONFIGURE=		yes
  CONFIGURE_ARGS+=	--with-html-dir=${PREFIX}/share/doc/html
+USE_LIBTOOL=		yes
  PKGCONFIG_OVERRIDE=	${WRKSRC}/gdome2.pc.in

  .include "../../devel/glib2/buildlink3.mk"


The changes from old libgdome.la to new are:

--- libgdome.la	2005-10-11 15:21:05.000000000 -0700
+++ /usr/pkg/lib/libgdome.la	2005-10-11 15:21:59.000000000 -0700
@@ -1,20 +1,20 @@
  # libgdome.la - a libtool library file
-# Generated by ltmain.sh - GNU libtool 1.4.2 (1.922.2.54 2001/09/11 
03:33:37)
+# Generated by ltmain.sh - GNU libtool 1.5.18 (1.1220.2.245 2005/05/16 
08:55:27)
  #
  # Please DO NOT delete this file!
  # It is necessary for linking the library.

  # The name that we can dlopen(3).
-dlname='libgdome.so.8'
+dlname='libgdome.so.0'

  # Names of this library.
-library_names='libgdome.so.8.1 libgdome.so.8 libgdome.so libgdome.so'
+library_names='libgdome.so.0.8.1 libgdome.so.0 libgdome.so'

  # The name of the static archive.
  old_library='libgdome.a'

  # Libraries that this one depends upon.
-dependency_libs=' -L/usr/pkg/lib -L/usr/lib /usr/pkg/lib/libiconv.la 
/usr/pkg/lib/libxml2.la -lz /usr/pkg/lib/libz.la -lm 
/usr/pkg/lib/libglib-2.0.la -lintl /usr/pkg/lib/libintl.la -liconv -lc'
+dependency_libs='-L/usr/pkg/lib -lxml2 -lz -lm -lglib-2.0 -lintl'

  # Version information for libgdome.
  current=8
@@ -24,9 +24,14 @@
  # Is this an already installed library?
  installed=yes

+# Should we warn about portability when linking against -modules?
+shouldnotlink=no
+
  # Files to dlopen/dlpreopen
  dlopen=''
  dlpreopen=''

  # Directory that this library needs to be installed in:
  libdir='/usr/pkg/lib'
+
+# This file has been modified by buildlink3.


And the changes in the installed library naming are:

  /usr/pkg/lib/libgdome.so
-/usr/pkg/lib/libgdome.so.8
-/usr/pkg/lib/libgdome.so.8.1
+/usr/pkg/lib/libgdome.so.0
+/usr/pkg/lib/libgdome.so.0.8.1
  /usr/pkg/lib/libgdome.la


No other packages depend on gdome2.

May I commit this? And bump BUILDLINK_DEPENDS.gdome2 in 
textproc/gdome2/buildlink3.mk ?

  Jeremy C. Reed

  	  	 	 Media Relations and Publishing Services
 	  	 	 http://www.reedmedia.net/