Subject: Re: Curious deprecated option handling
To: Jeroen Ruigrok/asmodai <email@example.com>
From: Dieter Baron <firstname.lastname@example.org>
Date: 09/04/2005 12:33:05
In article <20050904080726.GD49000@nexus.ninth-circle.org> Jeroen wrote:
: -On [20050904 01:17], Amitai Schlair (email@example.com) wrote:
: >The reason there's still code to deal with this variable, and the
: >others you mentioned, is that people may have chosen to set them in
: >mk.conf. We generally keep honoring such deprecated variables until
: >after the next quarterly pkgsrc branch has been cut.
: Yes, ok, I can understand that. But at present this deprecated option
: detection code will be crying wolf because it does *not* reflect the pkg's
: reality (as the warning message suggests), but rather old style handling in
: the pkgsrc infrastructure.
If the variable is not used by any package any longer (as seems to
be the case with DJB_ERRNO_HACK), it should no longer be defined.
Then, the warning is only triggered when the user defines it.
If the variable is still used by another package, its definition
must remain until all packages using it are converted to the options
: This is both misleading to users and pkg maintainers in my opinion.
True, but I think the effort is be better spent on converting the
remaining packages than improving the deprecation code (which will be
unused once all packages have been converted).