Subject: Re: patch for multimedia/gnome2-media for lrint(3)
To: Jeremy C. Reed <reed@reedmedia.net>
From: Johnny Lam <jlam@NetBSD.org>
List: tech-pkg
Date: 07/21/2005 14:24:54
Jeremy C. Reed wrote:
> 
> +# NetBSD before 3 and FreeBSD before 5.4 do not have lrint(3)
> +.if (${OPSYS} == "NetBSD" && (!empty(${OS_VERSION:M1.[0-5]*}) || \
> +        !empty(OS_VERSION:M2.0*))) || \
> +    (${OPSYS} == "FreeBSD" && (!empty(OS_VERSION:M4.*) && \
> +        !empty(OS_VERSION:M5.[0-3]*)))
> +SUBST_CLASSES+=        rint
> +SUBST_STAGE.rint=    pre-configure
> +SUBST_FILES.rint=    gnome-cd/gst-cdparanoia-cdrom.c 
> gst-mixer/src/volume.c
> +SUBST_SED.rint=        -e "s,lrint,rint,g"
> +.endif

I would much rather we patch the configure.{in,ac} file to add a feature 
test and modify the source files accordingly, than do this type of awful 
${OPSYS}-version checking.  We can feed these types of patches back to 
the GNOME project.

	Cheers,

	-- Johnny Lam <jlam@NetBSD.org>