Subject: add ${X11BASE}/bin into PREPEND_PATH when USE_X11 (was Re: kdebase3
To: Juan RP <juan@xtraeme.nopcode.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: tech-pkg
Date: 04/07/2005 11:44:51
On Thu, 7 Apr 2005, Juan RP wrote:

> To avoid future problems, we should add ${X11BASE}/bin into PREPEND_PATH,
> when USE_X11 is defined (no need for USE_IMAKE, because it already does).

Okay, I agree with that.

USE_MAKE sets USE_X11BASE which sets USE_X11.

So maybe mk/bsd.prefs.mk should have instead:

-PREPEND_PATH+=          ${LOCALBASE}/bin ${USE_IMAKE:D${X11BASE}/bin}
+PREPEND_PATH+=          ${LOCALBASE}/bin ${USE_X11:D${X11BASE}/bin}

For example:

rainier:/usr/pkgsrc/x11/Xaw3d$ make show-var VARNAME=PREPEND_PATH
/usr/pkg/bin /usr/X11R6/bin
/usr/pkg/tmp/pkgsrc/x11/Xaw3d/work.rainier/.gcc/bin
/usr/pkg/tmp/pkgsrc/x11/Xaw3d/work.rainier/.tools/bin
/usr/pkg/tmp/pkgsrc/x11/Xaw3d/work.rainier/.buildlink/bin
/usr/pkg/tmp/pkgsrc/x11/Xaw3d/work.rainier/.wrapper/bin

I do have a concern though. It seems like the wrapper/symlink directories
(under work) should be before ${LOCALBASE}/bin ${X11BASE}/bin in the
PATH.

 Jeremy C. Reed

 	  	 	 technical support & remote administration
	  	 	 http://www.pugetsoundtechnology.com/