Subject: Re: Qs re pkgsrc/mk/install/usergroup
To: Georg Schwarz <email@example.com>
From: Johnny Lam <jlam@NetBSD.org>
Date: 03/28/2005 14:29:38
Georg Schwarz wrote:
> I have a few questions regarding pkgsrc/mk/install/usergroup:
> - on the one hand it features
> case $group in
> on the other hand group_exists() is called like this:
> group_exists $group
> (similar for user_exists $user). Is the $group argument with which
> group_exists is called really necessary, or doesn't it have any effect
> since it not evaluated by the function anyway, but rather the fixed
> variable $group is read?
I've fixed this just now to work as intended. Thanks for pointing out
> - would it be a good idea to enclose variables in case expressions by
> double quotes?
I haven't seen any guidelines on this, and I don't have any experience
with shell scripting on non-NetBSD systems, so I just went with what
worked on NetBSD. If there are style guides that recommend this, please
feel free to add the appropriate quotes to the scripts.
-- Johnny Lam <jlam@NetBSD.org>