Subject: Re: net/ORBit: question regarding Makefile variable
To: Julio M. Merino Vidal <jmmv84@gmail.com>
From: Georg Schwarz <georg.schwarz@freenet.de>
List: tech-pkg
Date: 03/09/2005 18:08:42
> > I already did; and in fact I first thought that it was this patch's fault,
> > but after investigating more closely I think the patch is correct, because
> > ORBIT_HAVE_ALLOCA_H is supposed to be either 0 or 1.
> 
> No, it's not.  It's supposed to be defined or undefined, according to
> the semantics of the config.h file.

OK, that would be nice, but that's found in the Makefiles.

> 
> > > BTW, the alloca check is broken anyway: it includes alloca.h which is
> > > not present in NetBSD.  It should only include it in case HAVE_ALLOCA_H
> > > is set; otherwise, use stdlib.h.
> > 
> > Does ORBIT_HAVE_ALLOCA_H equal 0 or 1 on NetBSD?
> 
> It should be 1, but actually is 0 because alloca.h does not exist.

If it does not exist (and thus cannot be included), then why should it be 1?

-- 
Georg Schwarz    http://home.pages.de/~schwarz/
 georg.schwarz@freenet.de  +49 178 8545053