Subject: PKGSRC_PATCH_FAIL on unknown patch file (was Re: pkgsrc NetBSD
To: None <tech-pkg@netbsd.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: tech-pkg
Date: 02/16/2005 13:21:00
>  **************************************
>  Ignoring unknown patch file: /usr/pkgsrc/mail/oe2mbx/patches/patch-aa
>  **************************************

May I commit a fix to make it fail on unknown patch file?

This will stop problem with impartial commits.

I have been using following in bsd.pkg.mk for probably a couple months:

 					fi;				\
 					if [ "X$$algsum" = "X" -o "X$$recorded" = "X" ]; then \
 						${ECHO_MSG} "**************************************"; \
-						${ECHO_MSG} "Ignoring unknown patch file: $$i"; \
+						${ECHO_MSG} "Unknown patch file: $$i"; \
 						${ECHO_MSG} "**************************************"; \
-						continue;		\
+						${PKGSRC_PATCH_FAIL};		\
 					fi;				\
 					if [ "X$$calcsum" != "X$$recorded" ]; then \
 						${ECHO_MSG} "**************************************"; \
@@ -1895,9 +1910,9 @@
 					fi;				\
 				else					\
 					${ECHO_MSG} "**************************************"; \
-					${ECHO_MSG} "Ignoring unknown patch file: $$i"; \
+					${ECHO_MSG} "Unknown patch file: $$i"; \
 					${ECHO_MSG} "**************************************"; \
-					continue;			\
+					${PKGSRC_PATCH_FAIL};			\
 				fi;					\
 				;;					\
 			esac;						\

Jeremy C. Reed

 	  	 	 BSD News, BSD tutorials, BSD links
	  	 	 http://www.bsdnewsletter.com/