Subject: Re: Missing maintainers in bulk build reports
To: Julio M. Merino Vidal <jmmv@menta.net>
From: Todd Vierling <tv@duh.org>
List: tech-pkg
Date: 01/13/2005 14:53:06
On Thu, 13 Jan 2005, Julio M. Merino Vidal wrote:

> bulk build reports sometimes fail to get the correct value for the
> maintainer field because they grep the Makefile directly.  This is
> enough if the package has a single Makefile, but those that are
> "splitted" (i.e., Makefile.common) don't work properly.
>
> What do you think of the following patch, which uses bmake to get
> the maintainer if the grep failed?  (I can't test it.)

Looks OK, but the syntax is different now that I cleaned up post-build's
lexical scoping:

	if (!$maintainer) {
		$maintainer = `cd $vars{USR_PKGSRC}/$pkg ; $BMAKE show-var VARNAME=MAINTAINER`;
		chomp $maintainer;
	}

(Note that I have not tested this chunk either yet; I only converted the
syntax and added the "chomp".)

-- 
-- Todd Vierling <tv@duh.org> <tv@pobox.com>