Subject: bsd.wrapper.mk 1.16 and logic 1.8 + mysql4-*
To: None <tech-pkg@netbsd.org>
From: Juan RP <juan@xtraeme.nopcode.org>
List: tech-pkg
Date: 01/10/2005 16:58:59
--Signature=_Mon__10_Jan_2005_16_58_59_+0100_56/Rfu6OpG9k/9T8
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit


Hi, the following commit seems to break the mysql4-* packages:

Module Name:	pkgsrc
Committed By:	jlam
Date:		Mon Jan 10 03:40:25 UTC 2005

Modified Files:
	pkgsrc/mk/wrapper: bsd.wrapper.mk logic

Log Message:
Avoid the silly optimization in the make logic and push it into the
shell script instead.  We can't avoid invoking sed at least once since
we need to protect the arguments against shell expansion, but we avoid
invoking sed for transformations unless there actually are transformations
to perform.  The code is simpler, more straightforward, and logically
correct now.

This fixes problems with using a non-GCC compiler with packages that
haven't been converted to use buildlink3, noted in PR pkg/28896.

And the output for the error:

Making all in client
gmake[2]: Entering directory
`/usr/pkgsrc/databases/mysql4-client/work/mysql-4.1.8a/client' /bin/sh
../libtool --preserve-dup-deps --mode=link c++  -O3 -DDBUG_OFF -O2
-DUSE_OLD_FUNCTIONS -I/usr/include   -fno-implicit-templates -fno-exceptions
-fno-rtti -Dunix  -Wl,-R/usr/pkg/lib/mysql -L/usr/lib -Wl,-R/usr/lib
-Wl,-R/usr/pkg/lib  -o mysql  mysql.o readline.o sql_string.o completion_hash.o
-lreadline -lcurses -ltermcap ../libmysql/libmysqlclient.la  -lcrypt -lm  -lz
-L/usr/lib -lssl -lcrypto  c++ -O3 -DDBUG_OFF -O2 -DUSE_OLD_FUNCTIONS
-I/usr/include -fno-implicit-templates -fno-exceptions -fno-rtti -Dunix
-Wl,-R/usr/pkg/lib/mysql -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -o .libs/mysql
mysql.o readline.o sql_string.o completion_hash.o  -L/usr/lib -lreadline
-lcurses -ltermcap ../libmysql/.libs/libmysqlclient.so
-L/usr/pkgsrc/databases/mysql4-client/work/.buildlink/lib -lcrypt -lm -lz -lssl
-lcrypto -Wl,--rpath -Wl,/usr/pkg/lib/mysql ld: cannot find -lreadline
gmake[2]: *** [mysql] Error 1
gmake[2]: Leaving directory
`/usr/pkgsrc/databases/mysql4-client/work/mysql-4.1.8a/client' gmake[1]: ***
[all-recursive] Error 1 gmake[1]: Leaving directory
`/usr/pkgsrc/databases/mysql4-client/work/mysql-4.1.8a' gmake: *** [all] Error 2
*** Error code 2

Can you take a look at this problem please?

Thanks.


--Signature=_Mon__10_Jan_2005_16_58_59_+0100_56/Rfu6OpG9k/9T8
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (NetBSD)

iD8DBQFB4qZDypkLYVDran0RAq78AJ0Q+5JJiXuW8cxieQepp/7nkdEpZACeKhE7
k8rIN0JR95to+ZS8uSKF7Sw=
=/XHR
-----END PGP SIGNATURE-----

--Signature=_Mon__10_Jan_2005_16_58_59_+0100_56/Rfu6OpG9k/9T8--