Subject: Re: pkgsrc Linux 2.4.27-1-686/i386 bulk build results 2004-12-21
To: Jeremy C. Reed <reed@reedmedia.net>
From: Min Sik Kim <minskim@NetBSD.org>
List: tech-pkg
Date: 12/22/2004 01:53:56
On Tue, 21 Dec 2004 21:52:08 -0800 (PST)
"Jeremy C. Reed" <reed@reedmedia.net> wrote:

> > graphics/inkscape                  reed@reedmedia.net
> 
> This is this error:
> 
>  configure: error: XML::Parser perl module is required for intltool
> 
> I think this is the fourth package that I have seen with this problem. The
> fix is to patch the configure from perl to $INTL_PERL.
> 
> What changed to make this necessary?

The code to test the availability of perl and XML::Parser came from
intltool.m4, which had a bug using "perl" instead of $INTLTOOL_PERL.
Due to this bug, the test fails if the first "perl" in PATH is not
from pkgsrc and that "perl" doesn't have XML::Parser.  This bug was
fixed in the recent intltool, but there are still many packages with
"configure" generated before the fix.

We need to ask authors to regenerate their configure scripts using
up-to-date intltool.

Until all such packages are fixed, we can let intltool/buildlink3.mk
correct configure.  See the patch below.

--
Min Sik Kim


Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/intltool/buildlink3.mk,v
retrieving revision 1.5
diff -u -r1.5 buildlink3.mk
--- buildlink3.mk	2 Oct 2004 13:58:58 -0000	1.5
+++ buildlink3.mk	22 Dec 2004 07:49:22 -0000
@@ -27,6 +27,12 @@
 
 _CONFIGURE_POSTREQ+=	override-intltool
 
+SUBST_CLASSES+=		perl
+SUBST_MESSAGE.perl=	"Replacing hardcoded perl with INTLTOOL_PERL."
+SUBST_STAGE.perl=	post-patch
+SUBST_FILES.perl=	configure
+SUBST_SED.perl=	-e 's,if `perl -e "require XML::Parser,if `$$INTLTOOL_PERL -e "require XML::Parser,'
+
 .PHONY: override-intltool
 override-intltool:
 	${_PKG_SILENT}${_PKG_DEBUG}					\