Subject: Re: PR pkg/28685
To: Marc Recht <>
From: D'Arcy J.M. Cain <>
List: tech-pkg
Date: 12/18/2004 08:16:08
On Sat, 18 Dec 2004 14:01:04 +0100
Marc Recht <> wrote:
> > I would like to commit the fix I suggested in this PR. I don't know
> > if it is the perfect fix (see my comments) but if fixes this PR and
> > also fixes the py-postgresql bulk build.  If no one has a problem I
> > will commit the changes before the freeze is over.
> >
> >
> FWIW, I'd like to get rid of the postgresql*-client packages all 
> together and integrate them into the according libs package.

Yah, I never really understood splitting them.  After all, if you are
going to build the libs, you probably want to use them somehow which
means either also building the server or the client.  If you build the
client it depends on the server so that's everything.  If you build the
server, chances are you want the client in order to admin it and that's
everything again.  I am sure that there is some theoretical situation
that requires pieces but I can't imagine that it would be common

Anyway, I also came up with the following change in order not to
overwrite the binary when building the client.

Index: postgresql74-client/Makefile
RCS file: /cvsroot/pkgsrc/databases/postgresql74-client/Makefile,v
retrieving revision 1.8
diff -u -u -r1.8 Makefile
--- postgresql74-client/Makefile    10 Oct 2004 07:30:23 -0000  1.8
+++ postgresql74-client/Makefile    18 Dec 2004 13:07:45 -0000
@@ -22,6 +22,9 @@

+   ${RM} ${WRKSRC}/src/bin/pg_config
    ${EGREP} -v "^#" ${FILESDIR}/man.exclude > ${WRKDIR}/man_tar_exclude
    ${TAR} -zxm -C ${PREFIX}/man -X ${WRKDIR}/man_tar_exclude   \

However, that doesn't work because the install target rebuilds it and
then installs it.  I guess I need to change the Makefile.  Oh well.

D'Arcy J.M. Cain <>