On Mon, Oct 11, 2004 at 03:25:20PM -0700, Jeremy C. Reed wrote:
> On Fri, 24 Sep 2004, Johnny C. Lam wrote:
> 
> > .if empty(RCD_SCRIPTS_EXAMPLEDIR:M${PREFIX}/*)
> > PKG_FAIL_REASON+= \
> > 	"bsd.pkg.install.mk: RCD_SCRIPTS_EXAMPLEDIR can't be an absolute path."
> > .endif
> 
> I did this a little differently:
> 
> .if !empty(RCD_SCRIPTS_EXAMPLEDIR:M/*)
> 
> Hope that is okay.

Yes, your construct more accurately states what is not allowed.

> > FWIW, I think the change to use share/examples/rc.d is a good idea.
> > In general, the files in /usr/pkg/etc are all config files, and we
> > really shouldn't install stuff there that we don't want to be modified.
> 
> I have done the first step of the commits to make sure that the use of
> RCD_SCRIPTS_EXAMPLEDIR is now relative subdirectory of ${PREFIX}.
> 
> Then probably tomorrow I will change to share/examples/rc.d.
> 
> It was suggested that I bump the PKGREVISIONs for all the
> RCD_SCRIPTS-using packages.

The PKGREVISION bump is necessary since the binary packages will be
different.

> At this time we should also start working on an automated consistent
> output about using the rc.d scripts. (We should probably include all the
> output into the +DISPLAY file while we are at it.)

We need this info to be displayed at post-install time for binary
packages as well, so we should stick it in the INSTALL script.  I think
the best way to implement this is to modify pkg_{add,delete} to pass
PKG_DBDIR in the environment to the INSTALL and DEINSTALL scripts so
that we can place some auxiliary files in ${PKG_DBDIR}/${PKGNAME},
e.g. +DISPLAY.  This would give us the maximum flexibility when writing
INSTALL/DEINSTALL scripts.  This is, I think, a larger project than
changing the RCD_SCRIPTS_EXAMPLEDIR, so we can work on this after your
work on this project is completed.

	Cheers,

	-- Johnny Lam <jlam@NetBSD.org>