Subject: Re: Fixing nbsed [was: pkgsrc NetBSD 2.0_BETA/i386 bulk build results 2004-09-05]
To: Julio M. Merino Vidal <firstname.lastname@example.org>
From: Johnny C. Lam <jlam@NetBSD.org>
Date: 09/08/2004 08:16:02
On Wed, Sep 08, 2004 at 12:01:09AM +0200, Julio M. Merino Vidal wrote:
> On Sun, 5 Sep 2004 19:09:00 +0000 (UTC)
> Krister Walfridsson <email@example.com> wrote:
> > textproc/nbsed tech-pkg@NetBSD.org
> This package fails because it defines a symbol, EMPTY, inside an enum.
> However, this is already #defined by utmpx.h, which is pulled in by
> nbcompat.h, so the enum ends up with a numeric value in it and causes
> a syntax error.
> The easy fixes are to either change the name used in sed's defs.h to
> something else than EMPTY, or to #undef that constant before it's used
> to define the enum. The later is ugly, so I think we should go with
> the former (maybe using ARG_EMPTY or something like that).
> But... should this fix only be done in pkgsrc's sed? Or should we also
> apply it to the base sed? (to eliminate a difference and simplify
Just fix it in pkgsrc's nbsed for now. I'm aware that there are
namespace issues with using libnbcompat, and I will work to fix them
in the future, but there is no real reason to change the basesrc sed
since it's not doing anything wrong.
-- Johnny Lam <jlam@NetBSD.org>