Subject: Re: taking a long time to check maximum length of command line
To: Jeremy C. Reed <reed@reedmedia.net>
From: Julio M. Merino Vidal <jmmv@menta.net>
List: tech-pkg
Date: 08/31/2004 20:49:41
On Tue, 31 Aug 2004 11:23:49 -0700 (PDT)
"Jeremy C. Reed" <reed@reedmedia.net> wrote:

> On Tue, 31 Aug 2004, Julio M. Merino Vidal wrote:
> 
> > > For example on NetBSD/amiga 1.5.x I did in converters/libiconv
> 
> > The problem in this specific package is that it includes bsd.prefs.mk
> > very early, at which point USE_LIBTOOL and GNU_CONFIGURE are not yet
> > defined.  Moving that chunk of the Makefile below should fix the problem
> 
> Thanks.
> 
> > (but then, PKG_FAIL_REASON is "out of order")...
> 
> Do you mean for aesthetics? pkglint?

Yes; maybe pkglint complains... well, thinking a bit more, it will complain anyway because
of the conditional.

> Or is it okay to be out of order? (If so, I'll commit simple fix.)

Yes, I think so.

Cheers

-- 
Julio M. Merino Vidal <jmmv@menta.net>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/