Subject: pkgsrc/multimedia/xine-lib Optimization Problem
To: None <tech-pkg@NetBSD.org>
From: John R. Shannon <shannonjr@netbsd.org>
List: tech-pkg
Date: 08/02/2004 10:28:44
=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Re: pkg/25867 Compilation problem with gcc 3.4

Problem: There is a problem compiling multimedia/xine-lib in that the "extr=
a"=20
assembly language module zoom_filter_xmmx.c breaks when optimized. Some=20
googling indicates that this is also encountered with FreeBSD and Linux. Th=
e=20
solution taken in the xine CVS source tree is to simply eliminate the extra=
=20
mmx dependent modules.

The following patch does that:

# cat patch-aw
$NetBSD$

=2D --- src/post/goom/Makefile.in.orig      2004-06-20 18:23:58.000000000 -=
0600
+++ src/post/goom/Makefile.in
@@ -412,9 +412,6 @@ EXTRA_DIST =3D zoom_filter_mmx.c zoom_filt

 lib_LTLIBRARIES =3D xineplug_post_goom.la

=2D -@HAVE_FFMMX_TRUE@@PPC_ARCH_FALSE@extra_files =3D zoom_filter_mmx.c=20
zoom_filter_xmmx.c
=2D -@HAVE_FFMMX_TRUE@@PPC_ARCH_FALSE@MMX_CFLAG =3D -DHAVE_MMX
=2D -
 xineplug_post_goom_la_SOURCES =3D $(extra_files) xine_goom.c \
                                goom_core.c \
                                filters.c \
@@ -449,8 +446,6 @@ am__xineplug_post_goom_la_SOURCES_DIST =3D
        zoom_filter_xmmx.c xine_goom.c goom_core.c filters.c lines.c \
        ifs_display.c ifs.c graphic.c gfontlib.c gfontrle.c surf3d.c \
        surface.c tentacle3d.c
=2D -@HAVE_FFMMX_TRUE@@PPC_ARCH_FALSE@am__objects_1 =3D zoom_filter_mmx.lo \
=2D -@HAVE_FFMMX_TRUE@@PPC_ARCH_FALSE@      zoom_filter_xmmx.lo
 am_xineplug_post_goom_la_OBJECTS =3D $(am__objects_1) xine_goom.lo \
        goom_core.lo filters.lo lines.lo ifs_display.lo ifs.lo \
        graphic.lo gfontlib.lo gfontrle.lo surf3d.lo surface.lo \

Is it OK to commit (along with an updated distinfo) and close the reference=
d=20
PR?

=2D --=20

John R. Shannon
shannonjr@netbsd.org
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (NetBSD)

iEYEARECAAYFAkEOa7wACgkQOKbCxya4HYuFtgCePjkVtgShEdwvdLUpoC+ijnM/
4f0An2thRT1740Tmvcwq84PkCmc1QbqZ
=3DczAz
=2D----END PGP SIGNATURE-----