Subject: Re: Patch to resume transfers on pkgsrc (finally!)
To: Jeremy C. Reed <reed@reedmedia.net>
From: Juan RP <xtraeme@netbsd.org>
List: tech-pkg
Date: 07/24/2004 10:09:19
--Signature=_Sat__24_Jul_2004_10_09_19_+0200_AUJDXpw16Yd+dw8F
Content-Type: multipart/mixed;
 boundary="Multipart=_Sat__24_Jul_2004_10_09_19_+0200_qy.5YiuHuvpkAnk6"


--Multipart=_Sat__24_Jul_2004_10_09_19_+0200_qy.5YiuHuvpkAnk6
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

On Fri, 23 Jul 2004 21:59:20 -0700 (PDT)
"Jeremy C. Reed" <reed@reedmedia.net> wrote:

> On Sat, 24 Jul 2004, Juan RP wrote:
> 
> > I would like to commit this patch Monday if the comments are good, please
> > share suggestions or whatever.
> 
> +       if [ `echo $$dsize` != `echo $$tsize` ]; then                   \
> +               for res_site in $$sites; do                             \
> +                       ${ECHO_MSG} "===> Size mismatch, resuming transfer.";
> 
> Maybe should only resume transfer if the dsize is less that the expected
> tsize?

You are right.

Patch updated (changed -eq to -lt per Jeremy's suggestion) and updated the
comment when resuming the transfer.

What do you think guys now?

--Multipart=_Sat__24_Jul_2004_10_09_19_+0200_qy.5YiuHuvpkAnk6
Content-Type: application/octet-stream;
 name="pkgsrc_resume.diff"
Content-Disposition: attachment;
 filename="pkgsrc_resume.diff"
Content-Transfer-Encoding: base64

SW5kZXg6IGJzZC5wa2cubWsKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvcGtnc3JjL21r
L2JzZC5wa2cubWssdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTQ3NQpkaWZmIC11IC1yMS4xNDc1
IGJzZC5wa2cubWsKLS0tIGJzZC5wa2cubWsJNiBKdWwgMjAwNCAyMjo0OToxNiAtMDAwMAkxLjE0
NzUKKysrIGJzZC5wa2cubWsJMjQgSnVsIDIwMDQgMDc6NTQ6MTAgLTAwMDAKQEAgLTE0MTksNiAr
MTQxOSwyMSBAQAogIyBhZGRpbmcgcHJlLSogb3IgcG9zdC0qIHRhcmdldHMvc2NyaXB0cywgb3Zl
cnJpZGUgdGhlc2UuCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjCiAKKyMgUmVzdW1lIGEgcHJldmlvdXMgdHJhbnNmZXIsIG5v
dCBmaW5pc2hlZCB0b3RhbGx5LgorX1JFU1VNRV9UUkFOU0ZFUj0JCQkJCQkJXAorCWRzaXplPWAk
e0xTfSAtbCAke19ESVNURElSfS8kJGJmaWxlIHwgJHtBV0t9ICd7cHJpbnQgJCQ1fSdgOwlcCisJ
dHNpemU9YCR7QVdLfSAnL15TaXplLyAmJiAkJDIgPT0gJyJcIigkJGJmaWxlKVwiIicgeyBwcmlu
dCAkJDQgfScgJHtESVNUSU5GT19GSUxFfWAgfHwgdHJ1ZTsgXAorCWlmIFsgYGVjaG8gJCRkc2l6
ZWAgLWx0IGBlY2hvICQkdHNpemVgIF07IHRoZW4JCQlcCisJCWZvciByZXNfc2l0ZSBpbiAkJHNp
dGVzOyBkbwkJCQlcCisJCQkke0VDSE9fTVNHfSAiPT09PiAkJGJmaWxlIG5vdCBjb21wbGV0ZWQs
IHJlc3VtaW5nLi4uIjsJXAorCQkJY2QgJHtfRElTVERJUn07CQkJCQlcCisJCQkke0ZFVENIX0NN
RH0gJHtGRVRDSF9CRUZPUkVfQVJHU30gJHtGRVRDSF9SRVNVTUVfQVJHU30JXAorCQkJCSAkJHty
ZXNfc2l0ZX0kJHtiZmlsZX07CQkJXAorCQkJaWYgWyAkJD8gLWVxIDAgXTsgdGhlbgkJCQlcCisJ
CQkJYnJlYWs7CQkJCQlcCisJCQlmaTsJCQkJCQlcCisJCWRvbmU7CQkJCQkJCVwKKwlmaQogIwog
IyBEZWZpbmUgdGhlIGVsZW1lbnRhcnkgZmV0Y2ggbWFjcm9zLgogIwpAQCAtMTU5OSw3ICsxNjE0
LDggQEAKIAl1bnNvcnRlZF9zaXRlcz0iJHtTSVRFU18ke2ZldGNoZmlsZTpUOlMvPS8tLS99fSAk
e19NQVNURVJfU0lURV9CQUNLVVB9IjsgXAogCXNpdGVzPSIke09SREVSRURfU0lURVN9IjsJCQkJ
CVwKIAkke19DSEVDS19ESVNUX1BBVEh9OwkJCQkJCVwKLQkke19GRVRDSF9GSUxFfTsKKwkke19G
RVRDSF9GSUxFfTsJCQkJCQkJXAorCSR7X1JFU1VNRV9UUkFOU0ZFUn0KIC4gICAgICAgIGVuZGlm
ICMgZGVmaW5lZChfRkVUQ0hfTUVTU0FHRSkKIC4gICAgICBlbmRmb3IKIC4gICAgZW5kaWYgIyBJ
TlRFUkFDVElWRV9TVEFHRSA9PSBmZXRjaAo=

--Multipart=_Sat__24_Jul_2004_10_09_19_+0200_qy.5YiuHuvpkAnk6--

--Signature=_Sat__24_Jul_2004_10_09_19_+0200_AUJDXpw16Yd+dw8F
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFBAhkvypkLYVDran0RAjqXAKCz+juKX9w5r6FQrCEgvfmuwA0G/ACg0FFr
HI+CTv76dzhvh9bZrgZGfqo=
=EZER
-----END PGP SIGNATURE-----

--Signature=_Sat__24_Jul_2004_10_09_19_+0200_AUJDXpw16Yd+dw8F--