Subject: Re: Something is wrong with java-vm.mk and bl3?
To: Juan RP <juan@netbsd.graffitipr.org>
From: grant beattie <grant@NetBSD.org>
List: tech-pkg
Date: 07/09/2004 08:20:59
--H8ygTp4AXg6deix2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 07, 2004 at 01:19:53PM +0200, Juan RP wrote:

> > [juan@Nocturno][/usr/pkgsrc/mail/columba]> make
> > =3D=3D=3D> Checking for vulnerabilities in columba-1.0M2
> > =3D> Checksum OK for columba-unix-1.0_M2-bin.zip.
> > =3D=3D=3D> Extracting for columba-1.0M2
> > =3D=3D=3D> Required installed package sun-jre14-[0-9]*: sun-jre14-2.5 f=
ound
> > =3D=3D=3D> Required installed package sun-jre14-[0-9]*: sun-jre14-2.5 f=
ound
> > =3D=3D=3D> Required installed package sun-jdk14-[0-9]*: sun-jdk14-2.5 f=
ound
> > =3D=3D=3D> Required installed package sun-jdk14-[0-9]*: sun-jdk14-2.5 f=
ound
> > =3D=3D=3D> Required installed package unzip-[0-9]*: unzip-5.51 found
> >=20
> > Why there are two sun-jre and sun-jdk dependencies?

for the same reason there can be a multiple dependency listed for
any buildlink3 dependency - because buildlink3 picks the highest and
most specific pattern.

> Looks like the reason is it from java-vm.mk:
>=20
> BUILDLINK_DEPENDS.jdk?=3D                 jdk-[0-9]*
> BUILDLINK_DEPENDS.jdk12?=3D               jdk12-[0-9]*
> BUILDLINK_DEPENDS.jdk13?=3D               jdk13-[0-9]*
> BUILDLINK_DEPENDS.jdk14?=3D               jdk14-[0-9]*
> BUILDLINK_DEPENDS.sun-jdk13?=3D           sun-jdk13-[0-9]*
> BUILDLINK_DEPENDS.sun-jre13?=3D           sun-jre13-[0-9]*
> BUILDLINK_DEPENDS.sun-jdk14?=3D           sun-jdk14-[0-9]*
> BUILDLINK_DEPENDS.sun-jre14?=3D           sun-jre14-[0-9]*
> BUILDLINK_DEPENDS.blackdown-jdk13?=3D     blackdown-jdk13-[0-9]*
> BUILDLINK_DEPENDS.blackdown-jre13?=3D     blackdown-jre13-[0-9]*
> BUILDLINK_DEPENDS.kaffe?=3D               kaffe>=3D1.1.4
> BUILDLINK_DEPENDS.wonka?=3D               wonka-[0-9]*
>=20
> AFAIK we could remove it because the version is already defined in the
> buildlink3 files.

there is no problem with listing dependencies twice - they will be
flattened to a single dependency. from looking at this, I'm guessing
it is because pkgsrc requires kaffe>=3D1.1.4 while it doesn't care what
version of the others you install.

individual packages (or users) could ask for a more specific version
by having a DEPENDS on eg. kaffe>=3D1.1.5 which would result in
something like:

=3D=3D=3D> Required installed package kaffe>=3D1.1.4: kaffe>=3D1.1.5 found
=3D=3D=3D> Required installed package kaffe>=3D1.1.5: kaffe>=3D1.1.5 found

which is quite normal in the buildlink3 world. maybe the [0-9]*
patterns can go away, but I suspect the kaffe dependency pattern
should stay (knowing absolutely nothing about our java stuff).

grant.


--H8ygTp4AXg6deix2
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFA7cjLluYOb9yiFXoRAkFqAJ92Mo2DnFoKUhrrQ0T4nTppyUKrfQCfd8O7
pbcmxNjrRUk1Ptw9tUdIvD4=
=eZm1
-----END PGP SIGNATURE-----

--H8ygTp4AXg6deix2--