Subject: Re: CVS commit: pkgsrc/multimedia/gmplayer
To: None <>
From: grant beattie <>
List: tech-pkg
Date: 06/21/2004 19:41:53
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 21, 2004 at 05:42:03PM +1000, grant beattie wrote:

> > I already did that. Shared distinfo files are a good idea for packages
> > with identical distribution files. But that is not the case here.
> they share a number of files (iirc, gmplayer distfiles are a superset of
> mplayer) so it makes perfect sense to share the checksum info.
> and on the contrary, the maintenance nightmare is having *two separate*
> files with ~identical contents because shared contents is often missed
> when someone updates one or the other package.

ok, I've just looked and the fonts used by mplayer aren't used by
gmplayer, and the skins in gmplayer aren't used by mplayer. only 3
files out of ~25 are actually shared, so in hindsight it sort of makes
more sense this way, but there is still the issue of the main distfile
and the patches which are shared.

I have instead added a comment to mplayer-share/Makefile and
gmplayer/Makefile pointing out that both distinfo files must be
maintained, which will hopefully avoid distinfo lossage happening
again later.

well, it seemed like a good idea at the time.. :)


Content-Type: application/pgp-signature
Content-Disposition: inline

Version: GnuPG v1.2.4 (NetBSD)