Subject: Re: CVS commit: pkgsrc
To: Jim Wise <>
From: Alistair Crooks <>
List: tech-pkg
Date: 06/15/2004 18:00:37
And, lest we get into commit wars...

On Tue, Jun 15, 2004 at 12:36:07PM -0400, Jim Wise wrote:
> Hash: SHA1
> On Tue, 15 Jun 2004, Matthias Drochner wrote:
> >
> >Module Name:	pkgsrc
> >Committed By:	drochner
> >Date:		Tue Jun 15 16:17:48 UTC 2004
> >
> >Modified Files:
> >	pkgsrc/lang/tcl: Makefile
> >	pkgsrc/x11/tk: Makefile
> >
> >Log Message:
> >Don't --enable-threads for now. If we do this, all potential users of
> > (whether linking it in or dlopen() it) must be linked
> >against libpthread. This is something we can't guarantee.
> >Fixes bulk build error in py-imagingtk and numerous runtime problems.
> I am reversing this change.
> With this change, tcl is _not_ usable in threaded apps, while without
> this change, tcl is perfectly usable in non-threaded apps.
> The fix for a package which is incorrectly written is not to break the
> package it depends on, but do your job correctly when writing the
> package.
> With buildlink3, this is mind-numbingly easy to do.
> That you neither contacted the maintainer of this package, nor did the
> buildlink and dependent package changes which your change requires shows
> that you have not really thought this through.
> So, as I said, I am reversing this change.  Fix your own package, don't
> break others.

I'd be grateful if you could keep a civil tone to this, and refrain
from attacking other developers.  I can understand that you are upset,
but that is no excuse.

I don't think anyone is in a position to throw stones here -
Matthias's commit would have caused a lot of problems for us, and this
is unacceptable during a freeze.  But similarily, your original change
to make tk and tcl threaded, which also occurred during a freeze,
caused a lot of problems for others.  It also came out of the blue. 

Having said all that, I didn't see any mail from Matthias asking
whether it would be OK to disable tcl and tk's threading. So backing out
the change is the correct thing to do, in the circumstances.

All further changes to the tcl and tk packages to go past packages@
and receive approval from same from now until the end of the freeze,
please.  Anything not doing that will be backed out.