--X1bOJ3K7DJ5YkBrT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi,

On Fri, Jun 11, 2004 at 10:09:55AM +0100, Dick Davies wrote:
>=20
> I've tweaked the makefiles for apache2 to support mod_ldap and
> mod_auth_ldap, it's a bit rough and ready but seems to build OK.
>=20
> The only possible snag I see so far is that it builds them into
> Apache, but apxs doesn't work that well for these two as ldap support
> needs to be built into apr-util..
>=20
> Can anyone see any other problems before I send-pr?

yes.  build separate packages, don't hardcode it into apache2 Makefile.
see e.g., www/ap2-auth-mysql.

> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /pub/NetBSD-CVS/pkgsrc/www/apache2/Makefile,v
> retrieving revision 1.36
> diff -r1.36 Makefile
> 36a37,39
> > .if defined(USE_OPENLDAP) && ${USE_OPENLDAP} =3D=3D YES
> > APACHE_MODULES+=3D      ldap auth_ldap
> > .endif
> Index: Makefile.common
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /pub/NetBSD-CVS/pkgsrc/www/apache2/Makefile.common,v
> retrieving revision 1.8
> diff -r1.8 Makefile.common
> 7a8,14
> > .if defined(USE_OPENLDAP) && ${USE_OPENLDAP} =3D=3D YES
> > APR_CONFIGURE_ARGS+=3D --with-ldap
> > APU_CONFIGURE_ARGS+=3D --with-ldap
> >
> > .include "../../databases/openldap/buildlink3.mk"
> > .endif

regards,

--=20
-- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --

--X1bOJ3K7DJ5YkBrT
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAyYV2iwjDDlS8cmMRAmacAJ9wZ/SrBHE3J9dphGeI2X2HpfVJigCdGAtN
/S5gsgbL90YJepa+wtsy9Jo=
=+sty
-----END PGP SIGNATURE-----

--X1bOJ3K7DJ5YkBrT--