--Signature=_Sat__5_Jun_2004_20_28_19_+0200_ReBtT/ff0_0ec6Aq
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

On Sat, 5 Jun 2004 20:19:57 +0200
"Julio M. Merino Vidal" <jmmv@menta.net> wrote:

> On Saturday 05 June 2004 19:26, Juan Romero Pardines wrote:
> > Module Name:	pkgsrc
> > Committed By:	xtraeme
> > Date:		Sat Jun  5 17:26:56 UTC 2004
> >
> > Modified Files:
> > 	pkgsrc/emulators/openmsx: Makefile PLIST
> >
> > Log Message:
> > Install a simple script into ${PREFIX}/bin to run openmsx.
> 
> - No revision bump?
> - Use SH instead of /bin/sh.

True.

> - Use ECHO instead of ECHO_MSG.

I don't see any difference bettween them, yes I know, ECHO is shorter...

> - Create the script in post-build and install it in post-install.  These are
>   two different things conceptually, so each one belongs in a different stage.

Why is that? 

> - Why group commands?  Just do two separate echo's, one with > and
>   the second with >>.  I.e., no (), nor \'s.

And why not? :)

> - You may want to use WRKDIR instead of WRKSRC during the creation of this
>   file.  (This way, you ensure that it won't conflict with other files in the
>   distribution).

I'm already taking care about this.

> - And at last... the real binary doesn't take arguments?  If so, it's
>   impossible to pass them with this script.  You should append "$@" to the
>   exec call, so that arguments are passed properly.  Do it even if it does
>   not take arguments.  Things may change in the future.

You are right here, I forgot this...

-- 
	Juan RP <juan@xtraeme.unixbsd.org>

--Signature=_Sat__5_Jun_2004_20_28_19_+0200_ReBtT/ff0_0ec6Aq
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAwhDHypkLYVDran0RAhcSAJ4/sF9xyNEshFUzvx/SqJSR8EDHagCffq0y
AhIMmW/J/X1/KrlBQmKF9lY=
=SlUL
-----END PGP SIGNATURE-----

--Signature=_Sat__5_Jun_2004_20_28_19_+0200_ReBtT/ff0_0ec6Aq--