On Fri, 9 Apr 2004 15:32:40 -0700 (PDT)
"Jeremy C. Reed" <reed@reedmedia.net> wrote:

> Hello Martti and xfce4 users:
> 
> Here are patches for x11/xfce4-desktop  so it will use PKG_SYSCONFDIR.
> It appears that x11/xfce4-panel changes should be similar.
> 
> Does anyone want to do x11/xfce4-panel and xfce4-utils too?
> 
> Can I commit this for x11/xfce4-desktop? (I have only been using xfce4
> off-an-on for a little while, so I am not sure how to test these
> menu.xml files yet.)

This is definitely needed.

But I see a problem in your patch.  You are configuring the program with
--sysconfdir=${PKGSYSCONFBASE}.  (I know other packages do the same, some
of them done by my in the past... but this is not right).  Consider a user
does: PKG_SYSCONFDIR.xfce4-desktop=/etc/xfce4/desktop.  He'll end up with
files under /etc/xfce4/desktop/xfce4/*, though the last 'xfce4' part
shouldn't be there.

Instead, the program should be configured by --sysconfdir=${PKGSYSCONFDIR}
and remove the trailing 'xfce4' part of the path from the sources,
wherever they try to open a configuration file.  This will need a
PKG_SYSCONFSUBDIR=xfce4 setting in the package Makefile.

This may be a lot of work in some cases, but it seems to me it'll be easy
in this one ;)

Cheers

-- 
Julio M. Merino Vidal <jmmv@menta.net>
The NetBSD Project - http://www.NetBSD.org/