Subject: Re: add a MANDIR setting?
To: Jeremy C. Reed <reed@reedmedia.net>
From: Thomas Klausner <wiz@NetBSD.org>
List: tech-pkg
Date: 03/29/2004 20:08:19
Hi!

I don't think I want this (for me personally) but here are my
thoughts on how this should be done.

On Mon, Mar 29, 2004 at 09:25:42AM -0800, Jeremy C. Reed wrote:
> Is it okay if I add the following to official pkgsrc?
> 
> I'd like to add this even though packages are not converted -- since it
> will take a while.
> 
> mk/bsd.pkg.defaults.mk:
> 
> MAN_DIR?=       man
> # Pathname relative to ${PREFIX} of directory holding the
> # manual pages and man directories.
> # Possible: any path you like, e.g. share/man.
> # Default: man (i.e. /usr/pkg/man, /usr/X11R6/man)
> 
> (How are items sorted / added in mk/bsd.pkg.defaults.mk? The top sections
> are not in alphabetical order.)

The first one or two sections are essentially unsorted right now, and
the package specific section is sorted approximately by package name (which
should prefix the variables). Improvements, of course, always welcome.

> So that is why I chose _MANDIR instead of MANDIR or MAN_DIR for the final
> destination.

That's ok.

> It will take a long time to clean this up, but in the long run, I think it
> will make it easier to manage and probably have fewer patches (especially
> for those sources already using configure --mandir=).
> 
> Then we can start working on cleaning up these packages that use
> INSTALL_MAN_DIRS and INSTALL_MAN to install to ${_MANDIR}.
> 
> Should we have the PLISTs automatically fixed to switch any ^man/ with
> ${MAN_DIR} ?
> 
> Or should every PLIST be fixed (s,^man/,${_MANDIR},)?

I think you should do the latter, do the automatic stuff (adding
the configure argument, sedding the INSTALL_MAN* stuff), do a bulk
build, and fix the remaining breakage either by undoing the
corresponding PLIST changes or modifying/adding the necessary patches.

Cheers,
 Thomas