Subject: Re: mjpegtools patch review request
To: Christopher SEKIYA <wileyc@rezrov.net>
From: Thomas Klausner <wiz@NetBSD.org>
List: tech-pkg
Date: 03/27/2004 11:10:28
On Sat, Mar 27, 2004 at 02:54:37PM +0900, Christopher SEKIYA wrote:
> Wanting to use transcode to create MPEG1 files, I discovered that its mjpeg
> modules wanted to use a shared libmjpegutils library.
> 
> Per an old post by Bernd about this exact subject, I've modified mjpegutils in
> pkgsrc to create, install, and buildlink the shared library.  transcode is
> happier thereby.

Sounds ok, some more comments below:

> ? patches/patch-ad
> ? patches/patch-ae
> ? patches/patch-af
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/multimedia/mjpegtools/Makefile,v
> retrieving revision 1.7
> diff -u -r1.7 Makefile
> --- Makefile	11 Mar 2004 13:17:03 -0000	1.7
> +++ Makefile	27 Mar 2004 05:49:42 -0000
> @@ -1,6 +1,7 @@
>  # $NetBSD: Makefile,v 1.7 2004/03/11 13:17:03 recht Exp $
>  
>  DISTNAME=	mjpegtools-1.6.2
> +PKGREVISION=	2

1 should be enough :)

>  CATEGORIES=	multimedia
>  MASTER_SITES=	${MASTER_SITE_SOURCEFORGE:=mjpeg/}
>  
> @@ -24,6 +25,9 @@
>  # XXX fix me
>  CONFIGURE_ARGS+=	--without-avifile
>  
> +pre-configure:
> +	cd ${WRKSRC} && ./autogen.sh
> +

Please avoid this, and just add some more Makefile.in patches
corresponding to the Makefile.am changes. We try not to run
auto* for every build if possible.

Also, we usually have one file per patched file.

Cheers,
 Thomas