Subject: devel/zlib/buil{dlink3,tin}.mk
To: None <jlam@NetBSD.org>
From: Masao Uebayashi <uebayasi@pultek.co.jp>
List: tech-pkg
Date: 03/16/2004 16:00:05
Hi!

devel/zlib/buildlink3.mk sets BUILDLINK_DEPENDS.zlib unconditionally,
which doesn't look quite right to me.

	:
	.if !empty(ZLIB_BUILDLINK3_MK:M+)
	BUILDLINK_DEPENDS.zlib+=        zlib>=1.1.4nb1
	BUILDLINK_PKGSRCDIR.zlib?=      ../../devel/zlib
	.endif  # ZLIB_BUILDLINK3_MK
	:

(This conditional is only to protect this part to not evaluated
twice.)

If I understand correctly, the "BUILDLINK_DEPENDS.zlib+= ..." line
should _only_ appear at the very last of builtin.mk.

	:
	.if !empty(USE_BUILTIN.zlib:M[nN][oO])
	BUILDLINK_DEPENDS.zlib+=        zlib>=1.2.1
	.endif

(And version mismatch?)

Masao