Subject: patch for epiphany mkdir() (was Re: experiences with X11BASE as
To: Thomas Klausner <wiz@NetBSD.org>
From: Jeremy C. Reed <reed@reedmedia.net>
List: tech-pkg
Date: 02/06/2004 15:42:51
On Fri, 6 Feb 2004, Thomas Klausner wrote:

> >  ** ERROR **: Couldn't mkdir /home/reed/.gnome2/epiphany/favicon_cache/

> This is most probably the mkdir(2) problem -- NetBSD's mkdir(2) didn't
> accept a trailing slash when creating directories; try to remove
> the trailing slash in the source.
>
> This has been changed in -current, but for 1.6.x and older a patch would
> be appropriate.

Here is my patch-ab. Should I commit it?

$NetBSD$

--- embed/ephy-favicon-cache.c.orig	Fri Feb  6 14:55:43 2004
+++ embed/ephy-favicon-cache.c	Fri Feb  6 14:56:08 2004
@@ -263,7 +263,7 @@
 					          NULL);

 	cache->priv->directory = g_build_filename (ephy_dot_dir (),
-						   "favicon_cache/",
+						   "favicon_cache",
 						   NULL);

 	if (g_file_test (cache->priv->directory, G_FILE_TEST_IS_DIR) == FALSE)

I removed my .gnome2 directories and it worked fine.

Now I see the epiphany is not working for www.linux.com and www.nba.com
websites. I guess it is hanging at some flash or other add-on. (I assume
this is unrelated to my patch, although I never noticed before.


bigfour:/usr/pkgsrc/www/epiphany$ epiphany

** (epiphany-bin:13603): WARNING **: Web browser gnome icon not found

** (epiphany-bin:13603): WARNING **: Throbber animation not found

I am not sure what the filename is for icon so I don't know if it
is there or not. (probably the errors should show the actual file name.).


   Jeremy C. Reed
   http://www.reedmedia.net/