Subject: Re: should I use buildlink3.mk for new packages?
To: Jeremy C. Reed <reed@reedmedia.net>
From: Johnny C. Lam <jlam@buildlink.org>
List: tech-pkg
Date: 02/05/2004 02:03:52
On Wed, Feb 04, 2004 at 05:20:58PM -0800, Jeremy C. Reed wrote:
> 
> sysutils/file was missing zlib buildlink. So I used:
> 
> --- sysutils/file/Makefile	2003/07/21 17:24:14	1.4
> +++ sysutils/file/Makefile	2004/02/05 01:18:06
> @@ -9,10 +9,15 @@
>  #HOMEPAGE=
>  COMMENT=		Tool for determining file type
> 
> +PKG_INSTALLATION_TYPES=	overwrite pkgviews
> +
> +USE_BUILDLINK3= 	YES
>  GNU_CONFIGURE=		YES
>  CONFIGURE_ARGS+=	--enable-fsect-man5
>  CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR}
> 
>  MESSAGE_SUBST+=		PKG_SYSCONFDIR=${PKG_SYSCONFDIR}
> +
> +.include "../../devel/zlib/buildlink3.mk"
> 
>  .include "../../mk/bsd.pkg.mk"
> 
> I haven't used pkgviews with this. But the above seemed to do the right
> thing (which was use libz if needed).

You can skip adding the PKG_INSTALLATION_TYPES line as it only pertains
to pkgviews, and I'm not ready to actively support it in pkgsrc.  The
rest of this looks just fine though.  Please feel free to commit this.

	Cheers,

	-- Johnny Lam <jlam@buildlink.org>