Subject: Re: CVS commit: pkgsrc/devel/zlib
To: Johnny C. Lam <jlam@NetBSD.org>
From: grant beattie <grant@NetBSD.org>
Date: 01/26/2004 14:07:53
Content-Type: text/plain; charset=us-ascii
On Sun, Jan 25, 2004 at 11:24:47AM +0000, Johnny C. Lam wrote:
> > pkg_admin: ` ' not recognised
> > pkg_admin: `>' not recognised
> > pkg_admin: `=3D' not recognised
> This is fixed in the latest pkgsrc and was an oversight on my part.
> I thought I had caught all instances in pkgsrc where the value of
> BUILDLINK_DEPENDS.<pkg> was being checked, but I missed the most
> important buildlink3.mk file of all!
> BUILDLINK_DEPENDS.zlib=3D zlib>=3D1.2.2 # needs zfoo()
> .include "../../devel/zlib/buildlink3.mk"
> If we use =3D instead of +=3D to modify BUILDLINK_DEPENDS.zlib in
> zlib/buildlink3.mk, then it the resulting dependency will be
> zlib>=3D1.2.1, which is _not_ sufficient. By using +=3D to modify the
> value of BUILDLINK_DEPENDS.zlib, we ensure that all of the listed
> zlib dependency requirements end up in the dependency list so that
> the rest of the pkgsrc machinery can do the right thing.
right, that makes sense now.
> Can you please back out your change now that bsd.buildlink3.mk has
> been fixed?
yes, I've reverted the change. thanks!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)
-----END PGP SIGNATURE-----