Subject: Re: CVS commit: pkgsrc/devel/zlib
To: Johnny C. Lam <jlam@NetBSD.org>
From: grant beattie <grant@NetBSD.org>
List: tech-pkg
Date: 01/26/2004 14:07:53
--B3NBd8mrXZtPJEYR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 25, 2004 at 11:24:47AM +0000, Johnny C. Lam wrote:

> >     pkg_admin: ` ' not recognised
> >     pkg_admin: `>' not recognised
> >     pkg_admin: `=3D' not recognised
>=20
> This is fixed in the latest pkgsrc and was an oversight on my part.
> I thought I had caught all instances in pkgsrc where the value of
> BUILDLINK_DEPENDS.<pkg> was being checked, but I missed the most
> important buildlink3.mk file of all!

ah :)

> 	BUILDLINK_DEPENDS.zlib=3D	zlib>=3D1.2.2	# needs zfoo()
> 	.include "../../devel/zlib/buildlink3.mk"
>=20
> If we use =3D instead of +=3D to modify BUILDLINK_DEPENDS.zlib in
> zlib/buildlink3.mk, then it the resulting dependency will be
> zlib>=3D1.2.1, which is _not_ sufficient.  By using +=3D to modify the
> value of BUILDLINK_DEPENDS.zlib, we ensure that all of the listed
> zlib dependency requirements end up in the dependency list so that
> the rest of the pkgsrc machinery can do the right thing.

right, that makes sense now.

> Can you please back out your change now that bsd.buildlink3.mk has
> been fixed?

yes, I've reverted the change. thanks!

grant.


--B3NBd8mrXZtPJEYR
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAFISJluYOb9yiFXoRAtrFAKCMzrAc+faOXbxRDf03TLsHjsrsyACdGJDG
gHpNIlyuXMrioPowYHmwfCU=
=R3FS
-----END PGP SIGNATURE-----

--B3NBd8mrXZtPJEYR--