Subject: Re: Problem building devel/glib
To: None <tech-pkg@netbsd.org>
From: Johnny C. Lam <jlam@NetBSD.org>
List: tech-pkg
Date: 01/25/2004 18:54:36
--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jan 25, 2004 at 07:00:32PM +0100, Klaus Heinz wrote:
> Klaus Heinz wrote:
> 
> > I had the same problem and it works for me on NetBSD 1.5.3 now.
> 
> I spoke too soon:
> 
>   kh@silence:glib/ [108]$ make deinstall
>   ===> Deinstalling for glib
>   ===> Becoming root@silence to deinstall glib.
>   sudo cannot create =2.0.0:../../devel/pth _BLNK_ADD_TO.BUILD_DEPENDS=
>   _BLNK_ADD_TO.RECOMMENDED= real-su-deinstall DEINSTALLDEPENDS=NO:
>   directory nonexistent
>   *** Error code 2
> 
> It seems we're losing quotes in
>   _BLNK_ADD_TO.DEPENDS=" pth>=2.0.0:../../devel/pth"
> somewhere around the real-su-deinstall target.

Does the attached patch?  I'm unable to test this myself since my
pkgsrc development machine is in transit.

	Thanks,

	-- Johnny Lam <jlam@NetBSD.org>

--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="su.diff"

Index: bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1358
diff -u -r1.1358 bsd.pkg.mk
--- bsd.pkg.mk	25 Jan 2004 10:36:15 -0000	1.1358
+++ bsd.pkg.mk	25 Jan 2004 18:52:53 -0000
@@ -3248,9 +3248,13 @@
 		fi;                                             	\
 		${ECHO_MSG} "${_PKGSRC_IN}> Becoming root@`${HOSTNAME_CMD}` to $$action ${PKGBASE}."; \
 		${ECHO_MSG} -n "`${ECHO} ${SU_CMD} | ${AWK} '{ print $$1 }'` ";\
-		${SU_CMD} "cd ${.CURDIR}; ${SETENV} PATH=$${PATH}:${SU_CMD_PATH_APPEND} ${MAKE} $$args ${MAKEFLAGS} $$realtarget $$realflags"; \
+		${SU_CMD} "${_SU_CMDLINE:Q}";				\
 	fi
 
+_SU_CMDLINE=	cd ${.CURDIR};						\
+		${SETENV} PATH=$${PATH}:${SU_CMD_PATH_APPEND}		\
+		${MAKE} $$args ${MAKEFLAGS} $$realtarget $$realflags
+
 .PHONY: do-su-install
 do-su-install:
 	${_PKG_SILENT}${_PKG_DEBUG}					\

--M9NhX3UHpAaciwkO--