Subject: Re: bump BUILDLINK_DEPENDS.tiff and pkg/23515: graphics/tiff is broken under amd64
To: Jeremy C. Reed <firstname.lastname@example.org>
From: Johnny C. Lam <jlam@NetBSD.org>
Date: 11/21/2003 12:15:45
On Fri, Nov 21, 2003 at 02:24:53AM -0800, Jeremy C. Reed wrote:
> I am working on PR pkg/23515.
> On an amd64 system, libtiff didn't properly build for 64 bit. So other
> software using it didn't work correctly.
> I believe that the tiff/buildlink2.mk's BUILDLINK_DEPENDS.tiff needs to be
> increased. I understand that in some cases, the packages depending on it
> may need to be increased too. Please advise me on how to proceed.
> Maybe this will help other 64-bit machines too. (Can anyone test?)
> Below is the patch for graphics/tiff and also here are
> graphics/tiff/patches/patch-ah and graphics/tiff/patches/patch-ai.
Your patches just add "defined(_LP64)" to the files. If they worked
on alpha or sparc64 already, then your change has no effect for those
platforms. If they didn't work on those other 64-bit platforms, then
these changes got them working at last. In either case, we won't need
to bump the PKGREVISION for the tiff package since it doesn't affect
any existing binary packages.
Does our gcc not define __LP64__ as a preprocessor macro by default
on 64-bit machines? Is _LP64 in fact the correct macro to check? We
need to be sure before we make this change. Perhaps double check on
-- Johnny Lam <jlam@NetBSD.org>