Subject: Re: Netatalk 1.6.2 locking errors on -current?
To: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
From: Frederick Bruckman <fredb@immanent.net>
List: tech-pkg
Date: 09/28/2003 16:01:10
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--0-76049719-1064782870=:213
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Sun, 28 Sep 2003, Hauke Fath wrote:

> At 20:29 Uhr -0500 27.9.2003, Frederick Bruckman wrote:
> >
> >It looks like netatalk is up to 1.6.3, and one of the bugs fixed is in
> >AFP negotation. Worth a shot?

> Build in process... Btw, what should I make of (work/netatalk-163/config.log)?

Means nothing to me. Most "configure" tests are expected to fail...

> gmake[3]: Entering directory `/usr/src/pkgsrc/net/netatalk-163/work/netatalk-1.6.3/bin/afppasswd'
> if cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../include -I../../sys  -I/usr/include -I/usr/include/openssl -D_PATH_AFPDPWFILE=\"/etc/netatalk/afppasswd\"  -I/usr/pkg/include  -I../../sys/netbsd -I/usr/include/kerberosIV -I../../include -O2 -mcpu=v7 -mtune=v7 -I/usr/pkg/include -I../../sys -MT afppasswd.o -MD -MP -MF ".deps/afppasswd.Tpo" \
>   -c -o afppasswd.o `test -f 'afppasswd.c' || echo './'`afppasswd.c; \
> then mv -f ".deps/afppasswd.Tpo" ".deps/afppasswd.Po"; \
> else rm -f ".deps/afppasswd.Tpo"; exit 1; \
> fi
> afppasswd.c: In function `convert_passwd':
> afppasswd.c:89: error: `Key_schedule' undeclared (first use in this function)
> afppasswd.c:89: error: (Each undeclared identifier is reported only once
> afppasswd.c:89: error: for each function it appears in.)
> afppasswd.c:89: error: parse error before "schedule"
> afppasswd.c:108: error: `C_Block' undeclared (first use in this function)
> afppasswd.c:108: error: parse error before ')' token
> afppasswd.c:111: error: parse error before ')' token
> afppasswd.c:115: error: parse error before ')' token
> afppasswd.c:117: error: `schedule' undeclared (first use in this function)
> gmake[3]: *** [afppasswd.o] Error 1
>
> -- `Key_schedule' is defined in <des.h>, which gets included, and NCOMPAT is set nowhere...

Adding "-save-temps" to CFLAGS shows that <openssl/des.h> is getting
pulled in for <des.h>. I blame buildlink. ;-) The package doesn't
build out-of-the-box either, so it's hard to say for sure.

> Updated files for the package are in http://la.causeuse.org/hauke/NetBSD/netatalk-163-pkg.tgz
> Any ideas?

With the addition of two patches to change <des.h> to
<kerberosIV/des.h> (attached), I'm able to build it on
NetBSD-1.6ZC/i386. I haven't tried to install and run. The 1.6.1
machine that's serving the files is a K6-2, so a bit slower to build
on than the P4, and I think your set-up would provide a better run
test anyhow.

If the new package fixes the original problem, would you please wrap
this all up in a PR? I think we're in, or approaching, another freeze,
but there's no question this should go in, if it fixes your bug.

Frederick
--0-76049719-1064782870=:213
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=patch-ai
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.58.0309281601100.213@seduction.immanent.net>
Content-Description: patch-ai
Content-Disposition: attachment; filename=patch-ai

JE5ldEJTRCQNCg0KLS0tIGJpbi9hZnBwYXNzd2QvYWZwcGFzc3dkLmMub3Jp
ZwkyMDAzLTAxLTIxIDEwOjMzOjMwLjAwMDAwMDAwMCAtMDYwMA0KKysrIGJp
bi9hZnBwYXNzd2QvYWZwcGFzc3dkLmMNCkBAIC01Niw3ICs1Niw3IEBAIGNo
YXIgKnN0cmNociAoKSwgKnN0cnJjaHIgKCk7DQogDQogI2luY2x1ZGUgPG5l
dGF0YWxrL2VuZGlhbi5oPg0KIA0KLSNpbmNsdWRlIDxkZXMuaD4NCisjaW5j
bHVkZSA8a2VyYmVyb3NJVi9kZXMuaD4NCiANCiAjaWZkZWYgVVNFX0NSQUNL
TElCDQogI2luY2x1ZGUgPGNyYWNrLmg+DQo=

--0-76049719-1064782870=:213
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=patch-aj
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.58.0309281601101.213@seduction.immanent.net>
Content-Description: patch-aj
Content-Disposition: attachment; filename=patch-aj

JE5ldEJTRCQNCg0KLS0tIGV0Yy91YW1zL3VhbXNfcmFuZG51bS5jLm9yaWcJ
MjAwMy0wMS0yMSAxMDozMzozMS4wMDAwMDAwMDAgLTA2MDANCisrKyBldGMv
dWFtcy91YW1zX3JhbmRudW0uYw0KQEAgLTQ3LDcgKzQ3LDcgQEAgY2hhciAq
c3RyY2hyICgpLCAqc3RycmNociAoKTsNCiAjaW5jbHVkZSA8YXRhbGsvdWFt
Lmg+DQogDQogDQotI2luY2x1ZGUgPGRlcy5oPg0KKyNpbmNsdWRlIDxrZXJi
ZXJvc0lWL2Rlcy5oPg0KIA0KICNpZmRlZiBVU0VfQ1JBQ0tMSUINCiAjaW5j
bHVkZSA8Y3JhY2suaD4NCg==

--0-76049719-1064782870=:213--