Subject: Re: Postgresql-server compile failes on mac68k
To: =?ISO-8859-1?Q?R=E9mi_Zara?= <remi_zara@mac.com>
From: =?ISO-8859-1?Q?R=E9mi_Zara?= <remi_zara@mac.com>
List: tech-pkg
Date: 09/22/2003 21:48:01
Hi,

The following patch makes the file compile again. registers were =20
missing the '%' prefix.
Not sure however that that is the correct way to correct the issue.

But when it laters links the file, the following error occurs:

access/SUBSYS.o: In function `XLogWrite':
access/SUBSYS.o(.text+0x19dbc): undefined reference to `tas'
access/SUBSYS.o: In function `XLogInsert':
access/SUBSYS.o(.text+0x19470): undefined reference to `tas'
access/SUBSYS.o(.text+0x19a38): undefined reference to `tas'
access/SUBSYS.o: In function `AdvanceXLInsertBuffer':
access/SUBSYS.o(.text+0x19b94): undefined reference to `tas'
access/SUBSYS.o: In function `XLogFlush':
access/SUBSYS.o(.text+0x1a358): undefined reference to `tas'
access/SUBSYS.o(.text+0x1c844): more undefined references to `tas' =20
follow


Regards,

R=E9mi Zara

--- postgresql-7.3.4/src/backend/storage/lmgr/s_lock.c  Sat Sep 21 =20
02:14:05 2002
+++ s_lock.c    Mon Sep 22 20:51:25 2003
@@ -99,13 +99,13 @@
                                                                         =
=20
          "\
  .global                _tas                            \n\
  _tas:                                                  \n\
-                       movel   sp@(0x4),a0     \n\
-                       tas     a0@                     \n\
+                       movel   %sp@(0x4),%a0   \n\
+                       tas     %a0@                    \n\
                         beq     _success        \n\
-                       moveq   #-128,d0        \n\
+                       moveq   #-128,%d0       \n\
                         rts                                     \n\
  _success:                                              \n\
-                       moveq   #0,d0           \n\
+                       moveq   #0,%d0          \n\
                         rts                                     \n\
  ");
  }

Le samedi, 20 sep 2003, =E0 16:01 Europe/Paris, R=E9mi Zara a =E9crit :

> Hi,
>
> I'm trying to compile postgresql 7.3.4 from today's pkgsrc on my =20
> mac68k (1.6_RC2).
> It fails in postgresql-server:
>
> gmake[2]: Entering directory =20
> `/usr/pkgsrc/databases/postgresql-server/work/postgresql-7.3.4/src/=20
> backend/storage/lmgr'
> cc -O2 -I/usr/pkg/include -Wall -Wmissing-prototypes =20
> -Wmissing-declarations -I../../../../src/include -I/usr/pkg/include  =20=

> -I/usr/include  -c -o lmgr.o lmgr.c
> cc -O2 -I/usr/pkg/include -Wall -Wmissing-prototypes =20
> -Wmissing-declarations -I../../../../src/include -I/usr/pkg/include  =20=

> -I/usr/include  -c -o lock.o lock.c
> cc -O2 -I/usr/pkg/include -Wall -Wmissing-prototypes =20
> -Wmissing-declarations -I../../../../src/include -I/usr/pkg/include  =20=

> -I/usr/include  -c -o proc.o proc.c
> cc -O2 -I/usr/pkg/include -Wall -Wmissing-prototypes =20
> -Wmissing-declarations -I../../../../src/include -I/usr/pkg/include  =20=

> -I/usr/include  -c -o deadlock.o deadlock.c
> cc -O2 -I/usr/pkg/include -Wall -Wmissing-prototypes =20
> -Wmissing-declarations -I../../../../src/include -I/usr/pkg/include  =20=

> -I/usr/include  -c -o lwlock.o lwlock.c
> cc -O2 -I/usr/pkg/include -Wall -Wmissing-prototypes =20
> -Wmissing-declarations -I../../../../src/include -I/usr/pkg/include  =20=

> -I/usr/include  -c -o spin.o spin.c
> cc -O2 -I/usr/pkg/include -Wall -Wmissing-prototypes =20
> -Wmissing-declarations -I../../../../src/include -I/usr/pkg/include  =20=

> -I/usr/include  -c -o s_lock.o s_lock.c
> s_lock.c:97: warning: `tas_dummy' defined but not used
> /var/tmp/ccBABnyM.s: Assembler messages:
> /var/tmp/ccBABnyM.s:90: Error: syntax error -- statement `movel =20
> sp@(0x4),a0' ignored
> /var/tmp/ccBABnyM.s:91: Error: syntax error -- statement `tas a0@' =20
> ignored
> /var/tmp/ccBABnyM.s:93: Error: operands mismatch -- statement `moveq =20=

> #-128,d0' ignored
> /var/tmp/ccBABnyM.s:96: Error: operands mismatch -- statement `moveq =20=

> #0,d0' ignored
> gmake[2]: *** [s_lock.o] Erreur 1
> gmake[2]: Leaving directory =20
> `/usr/pkgsrc/databases/postgresql-server/work/postgresql-7.3.4/src/=20
> backend/storage/lmgr'
> gmake[1]: *** [lmgr-recursive] Erreur 2
> gmake[1]: Leaving directory =20
> `/usr/pkgsrc/databases/postgresql-server/work/postgresql-7.3.4/src/=20
> backend/storage'
> gmake: *** [storage-recursive] Erreur 2
> *** Error code 2
>
> Anyone knows what might be the problem there ?
>
> Thanks in advance,
>
> R=E9mi Zara
> --
> R=E9mi Zara
> web: http://www.remi-zara.net/
>
>
--
R=E9mi Zara
web: http://www.remi-zara.net/