Subject: Re: Passing CC in MAKE_FLAGS
To: David Brownlee <abs@netbsd.org>
From: Alistair Crooks <agc@wasabisystems.com>
List: tech-pkg
Date: 06/06/2003 20:08:40
On Fri, Jun 06, 2003 at 06:11:38PM +0100, David Brownlee wrote:
> 	Does anyone object to the following patch?
> 
> 	The intention is to ensure that if CC is set (eg: by having gcc3
> 	installed and including its mk file), packages that do not have
> 	a configure still pick up on CC.
> 
> Index: bsd.pkg.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
> retrieving revision 1.1188
> diff -u -r1.1188 bsd.pkg.mk
> --- bsd.pkg.mk	2003/06/01 23:59:07	1.1188
> +++ bsd.pkg.mk	2003/06/06 17:01:25
> @@ -300,6 +300,9 @@
>  MAKE_ENV+=		X11BASE=${X11BASE} CFLAGS="${CFLAGS}"
>  MAKE_ENV+=		CPPFLAGS="${CPPFLAGS}" FFLAGS="${FFLAGS}"
>  MAKE_ENV+=		X11PREFIX=${X11PREFIX}
> +.if defined(CC)
> +MAKE_ENV+=		CC=${CC}
> +.endif
> 
>  .if exists(${ZOULARISBASE}/bin/ftp)			# Zoularis
>  FETCH_CMD?=		${ZOULARISBASE}/bin/ftp

Sounds good to me, but can we have it quoted, please?

Thanks,
Al