Subject: Re: package menus
To: Wojciech Puchar <>
From: Douwe Kiela <>
List: tech-pkg
Date: 04/08/2003 20:01:14
I think it would be better it you would document this a little bit more..
A little bit of commenting would be very welcome, especially in the
wm_fvwm2.c file... you expect someone who wants to make for example
a Blackbox menu file to understand how fvwm menu files work before he can
understand what the code is really doing?
I would really appreciate more documentation on HOW you actually do it..
I can probably understand, but I had a short look at the code and already
found this bug:

Parsing input...
Segmentation fault (core dumped)

There are also several buffer overflows in your code.. If you want me to I
can fix these
later, but for now, try to change all strcpy()'s and strcat()'s into
strncpy()'s and strncat()'s.
If someone's stupid enough to run your program suid root, it'd be very easy
exploitable so
it's better to avoid that.

I think it's a great idea to make this, and I'd be glad to help you with
it.. You think you can get
a cvs repository up for this so multiple people can work on it more easilly?

Douwe Kiela

----- Original Message -----
From: "Wojciech Puchar" <>
To: <>
Sent: Tuesday, April 08, 2003 6:40 PM
Subject: package menus

> i did small program that can be used as separate package to generate menus
> for installed window managers and programs.
> as it's independent from any packages it's easy to maintain and use (no
> need to wait every package maintainer to add support).
> it's in
> now it can only generate fvwm/fvwm2 definitions (as i use only fvmw2) but
> adding support for anything else requires only
> 1) adding it to the list in wm_gen.c
> 2) copy wm_fvwm2.c to wm_yourwm.c
> 3) based on this code write code for your wm. it shouldn't be more than
> one-two screens :)
> please read menus.txt header to know how to use it and how to add more
> definitions or messages in more languages.
> And please send me all enhancements back so i will be able to make it more
> complete and finally make pkgsrc package with this program