Subject: Re: emulators/suse*/Makefile*
To: Jan Schaumann <email@example.com>
From: Frederick Bruckman <firstname.lastname@example.org>
Date: 03/23/2003 18:51:14
On Sun, 23 Mar 2003, Jan Schaumann wrote:
> I find it a bit confusing that emulators/suse*/Makefile.application and
> friends include mk/bsd.pkg.mk themselves -- virtually no other files
> that may be included by other packages do so. I believe that we should
> change that:
> - any package that includes suse*/Makefile.application (or .common or
> whatnot) should also, just as every other package, include
> mk/bsd.pkg.mk as the last file.
> - suse*/Makefile* should not include bsd.pkg.mk
Sounds good to me, in principle.
> The patch at
> http://guinness.cs.stevens-tech.edu/~jschauma/netbsd/suse.diff does
> that, and bumps PKGREVISIONS accordingly. Should that be applied or
> does anybody see any problems with this?
There's no need to bump PKGREVISION's, as there would be no functional
change to the resulting binary packages.
> On that note: I know we've at least mentioned it several times, but I
> can't recall a resolution: why does mk/bsd.pkg.mk not ifdef it's
> contents so as to avoid duplicate inclusion? All other .mk files do...
Have you tried that? I think it might break some of the
transformed-in-place variables. I have often thought, however, that
many of the one-shot utility targets could be moved into a separate
file, and only included once.