Subject: Re: phpize/libtoolize & existing libtool
To: David Brownlee <abs@netbsd.org>
From: Johnny C. Lam <jlam@netbsd.org>
List: tech-pkg
Date: 01/27/2003 12:59:46
--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 27, 2003 at 03:31:55PM +0000, David Brownlee wrote:
> 	Redhat 7.3 already has libtool installed. This doesn't seem to
> 	be a problem until we get to installing php packages. php comes
> 	with a 'phpize' script that setsup the build environment for
> 	php modules. phpize calls libtoolize without specifying a path.
> 	This calls the wrong libtoolize which doesn't create ltconfig,
> 	resulting in much entertaining breakage later.
> 
> 	Obvious thought would be to patch phpize to have a explicit
> 	path for libtoolize...

Does the following fix things?  We don't actually want phpize explicitly
calling /usr/pkg/bin/libtool because then we wouldn't be able make PHP4
modules buildlink2-safe.

	Cheers,

	-- Johnny Lam <jlam@netbsd.org>

--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff

Index: Makefile.module
===================================================================
RCS file: /cvsroot/pkgsrc/www/php4/Makefile.module,v
retrieving revision 1.21
diff -u -r1.21 Makefile.module
--- Makefile.module	2002/10/14 06:21:18	1.21
+++ Makefile.module	2003/01/27 20:58:28
@@ -50,7 +50,7 @@
 	if [ ! -f $${cookie} ]; then					\
 		( cd ${WRKSRC} && ${SETENV} AUTOCONF=${AUTOCONF}	\
 			AUTOHEADER=${AUTOHEADER} ACLOCAL=${ACLOCAL}	\
-			${PHPIZE} );					\
+			${MAKE_ENV} ${PHPIZE} );			\
 		${TOUCH} ${TOUCH_FLAGS} $${cookie};			\
 	fi
 

--ReaqsoxgOBHFXBhH--