Subject: Re: imap-uw and Malformed conditional ((${USE_KERBEROS} != "no"))
To: Lubomir Sedlacik <salo@Xtrmntr.org>
From: Roland Dowdeswell <elric@imrryr.org>
List: tech-pkg
Date: 12/15/2002 02:12:27
On 1039935765 seconds since the Beginning of the UNIX epoch
Lubomir Sedlacik wrote:
>

>that conditional is apparently wrong because it will fail (as it did for
>you) when USE_KERBEROS is not set.  try this patch:

>@@ -29,7 +29,7 @@
> ALL_TARGET=3D	osx
> .else
> ALL_TARGET=3D	neb
>-.if (${USE_KERBEROS} !=3D "no")
>+.if defined(USE_KERBEROS) && (${USE_KERBEROS} !=3D "no")
> PKG_USE_KERBEROS=3D	#defined
> ALL_TARGET+=3D	EXTRAAUTHENTICATORS=3D"gss"
> .endif

Well, yes and no.  That was my mistake, but it does work on more
recent NetBSD's because USE_KERBEROS is set by bsd.own.mk.  What
I forgot was that variable is not used by 1.5 or prior.  That said,
the easiest solution would be to either conditionally set it in
the pkgsrc mk files, or to use a solution similar to the one that
you proposed.

It may make sense to have the pkgsrc mk files initialise the value
of USE_KERBEROS from KERBEROS which is the 1.5 way of doing things.

Also, this should default to true, I think.  Which would imply
something more like:

.if !defined(USE_KERBEROS) || (${USE_KERBEROS} != "no")

--
    Roland Dowdeswell                      http://www.Imrryr.ORG/~elric/