hi,

> It seems to me that PKGSRC_RUN_TEST should be done as the last action
> step in the "build" target instead of the first action step in "install"
> target.  I.e. like this:

  It is not run as the first step in the install target, it is a
target on the same level as build and install.  (PKGSRC_RUN_TEST,
however, makes it a pre-requisit for install, so it is the first
action taken on ``make install' after a ``make build'' or ``make''.)

  This distinction is important, since ``make test'' should run the
tests regardless of the setting of PKGSRC_RUN_TEST.  (That variable
only controls if tests are run automatically before installing a
package.)

  That said, I understand your concern that running the tests when you
type ``make install'' is not entirely appropriate.  Would changing the
all target to test if PKGSRC_RUN_TEST is set be an acceptable
solution?  With that change, if you ran ``make'' followed by ``make
install'', the tests would run at the end of the first make.

						yours,
						dillo