Subject: pkgdiff reports unnecessary changes
To: None <tech-pkg@netbsd.org>
From: Klaus Heinz <k.heinz.nov.zwei@onlinehome.de>
List: tech-pkg
Date: 11/20/2002 20:02:00
Hi,

I observe a change in the output of patchdiff/pkgdiff.

  $ cd /usr/pkgsrc/mail/spamassassin
  $ make patch
  $ mkpatches
  $ patchdiff
  ...  

  Comparing patches/patch-ae to
  ../../../workobj-pkgsrc/mail/spamassassin/work.i386/.newpatches/patch-af
  5c5
  < @@ -831,7 +831,8 @@
  ---
  > @@ -831,7 +831,8 @@ sub cleanupchildren {
  Comparing patches/patch-ab to
  ../../../workobj-pkgsrc/mail/spamassassin/work.i386/.newpatches/patch-aa
  5c5
  < @@ -134,8 +134,8 @@
  ---
  > @@ -134,8 +134,8 @@ INST_PREFIX     = $instprefix

  ...

  Comparing patches/patch-ad to
  ../../../workobj-pkgsrc/mail/spamassassin/work.i386/.newpatches/patch-ae
  13c13
  < @@ -34,6 +35,6 @@
  ---
  > @@ -34,6 +35,6 @@ command_args="-d -r ${pidfile}"

  ...


The additional output after '@@' seems to be caused by the option '-p'
('Show which C function each change is in') for 'diff' in the 'pkgdiff'
script.

I never saw this before and cannot explain why it happens now. As far as
I can see, there have been no changes to the script 'pkgdiff' in the
recent past, only to the Makefile.

This is pkgdiff-0.107 on NetBSD 1.5.4_ALPHA.

Does this happen for others as well?

ciao
     Klaus