--jCrbxBqMcLqd4mOl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi,

is there any reason why converters/libiconv shouldn't be excluded from
building on Solaris and GNU/Linux?  iconv() is a part of libc on these
systems and this package is redundant (it has even PLIST.SunOS..)

since there are too many packages which include libiconv buildlink.mk,
the fix should go there.  i made following changes:

 1) removed PLIST.SunOS
 2) added NOT_FOR_PLATFORM=3D SunOS-*-* Linux-*-* to Makefile
 3) added check into buildlink.mk based on OPSYS

patch:

Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/pkgsrc/converters/libiconv/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- Makefile	14 May 2002 15:57:55 -0000	1.9
+++ Makefile	7 Jul 2002 03:53:37 -0000
@@ -10,18 +10,14 @@
 HOMEPAGE=3D		http://www.gnu.org/software/libiconv/
 COMMENT=3D		character set conversion library
=20
+NOT_FOR_PLATFORM=3D	SunOS-*-* Linux-*-*
+
 USE_BUILDLINK_ONLY=3D	YES
 GNU_CONFIGURE=3D		YES
 USE_GMAKE=3D		YES
 USE_LIBTOOL=3D		YES
 LIBTOOL_OVERRIDE+=3D	${WRKSRC}/libtool
 LIBTOOL_OVERRIDE+=3D	${WRKSRC}/libcharset/libtool
-
-.include "../../mk/bsd.prefs.mk"
-
-.if (${OPSYS} =3D=3D SunOS)
-PLIST_SRC=3D		${PKGDIR}/PLIST.${OPSYS}
-.endif
=20
 # remove any existing charset.alias; if it already exists, libiconv does
 # not overwrite it, and older versions of libiconv wrote incorrect
Index: buildlink.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/pkgsrc/converters/libiconv/buildlink.mk,v
retrieving revision 1.10
diff -u -r1.10 buildlink.mk
--- buildlink.mk	14 May 2002 15:57:55 -0000	1.10
+++ buildlink.mk	7 Jul 2002 03:53:37 -0000
@@ -16,7 +16,14 @@
 ICONV_BUILDLINK_MK=3D	# defined
=20
 .include "../../mk/bsd.buildlink.mk"
+.include "../../mk/bsd.prefs.mk"
=20
+_NEED_LIBICONV=3D		YES
+.if (${OPSYS} =3D=3D SunOS) || (${OPSYS} =3D=3D Linux)
+_NEED_LIBICONV=3D		NO
+.endif
+
+.if ${_NEED_LIBICONV} =3D=3D "YES"
 BUILDLINK_DEPENDS.iconv?=3D	libiconv>=3D1.7nb2
 DEPENDS+=3D	${BUILDLINK_DEPENDS.iconv}:../../converters/libiconv
=20
@@ -32,5 +39,6 @@
=20
 pre-configure: ${BUILDLINK_TARGETS.iconv}
 iconv-buildlink: _BUILDLINK_USE
+.endif  # _NEED_LIBICONV
=20
 .endif	# ICONV_BUILDLINK_MK


i filled a PR for this, it's pkg/17500.  can please someone check this
on Darwin/Mac OS X?  thanks.


regards,

--=20
-- Lubomir Sedlacik <salo@Xtrmntr.org>   ASCII Ribbon campaign against  /"\=
 --
--                  <salo@silcnet.org>   e-mail in gratuitous HTML and  \ /=
 --
--                                       Microsoft proprietary formats   X =
 --
-- PGPkey: http://Xtrmntr.org/salo.pgp                                  / \=
 --
-- Key Fingerprint: DBEC 8BEC 9A90 ECEC 0FEF  716E 59CE B70B 7E3B 70E2     =
 --

--jCrbxBqMcLqd4mOl
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (NetBSD)

iD8DBQE9J73lWc63C347cOIRAnvrAJ4ync2wmj5YifXhrYO3r7xLzC0qhQCdGDSW
43iPZ2sj4JPWUQAceNUeWbE=
=//EY
-----END PGP SIGNATURE-----

--jCrbxBqMcLqd4mOl--