Subject: Re: Optimization flags in pkgs
To: Martin Husemann <martin@duskware.de>
From: Johnny C. Lam <jlam@netbsd.org>
List: tech-pkg
Date: 06/06/2002 16:29:39
On Thu, Jun 06, 2002 at 11:48:40PM +0200, Martin Husemann wrote:
> 
> Module Name:    pkgsrc
> Committed By:   grant
> Date:           Thu Jun  6 08:09:08 UTC 2002
> 
> Modified Files:
>         pkgsrc/emulators/bochs: Makefile
> 
> Log Message:
> add CXXFLAGS=-O2
> reported by Wojciech Puchar <wojtek@3miasto.net> in pkg/17181.
> --->8---
> 
> I wonder if hardcoding -O2 here is a good idea.
> Wouldn't it be better to use the arch specific default setting from sys.mk?

Yes, hardcoding -O2 is mostly likely the wrong at any time.  We only
hardcode an optimization level when we need -O0 to work around some
codegen bug in gcc or egcs.  It's probably better to have:

	CXXFLAGS=	${CFLAGS}

and rely on /etc/mk.conf to include the correct optimization settings.

	Cheers,

	-- Johnny Lam <jlam@netbsd.org>