Subject: OK to remove "check-depends"?
To: None <tech-pkg@NetBSD.ORG>
From: Frederick Bruckman <fredb@immanent.net>
List: tech-pkg
Date: 03/04/2002 14:01:33
"check-depends" is the target that used to force installation of all
dependencies before permitting a "fetch". Whether intentionally or
not, it's no longer ever invoked, as "real-fetch" is defined
unconditionally earlier in "bsd.pkg.mk".

At one time, I believe it was requested behavior not to permit a
"fetch" unless the dependencies were satisfied (or satisfiable), but
now that everything mostly builds, the need for this behavior has
passed, and nobody seems to miss it. I sure don't. So does anybody
mind if "check-depends" just goes away (patch follows)?

Index: bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.941
diff -u -r1.941 bsd.pkg.mk
--- bsd.pkg.mk	2002/03/04 19:41:03	1.941
+++ bsd.pkg.mk	2002/03/04 19:53:28
@@ -1084,7 +1084,7 @@
 #
 .  if defined(IGNORE)
 fetch checksum extract patch configure all build install package \
-install-depends check-depends:
+install-depends:
 .    if defined(IGNORE_SILENT)
 	@${DO_NADA}
 .    else
@@ -3211,18 +3211,6 @@
 .    endif	# !NO_DEPENDS
 .  endif	# DEPENDS

-.endif
-
-real-fetch: check-depends
-.if !target(check-depends)
-check-depends:
-.  if (defined(DEPENDS) || defined(BUILD_DEPENDS)) && \
-      !defined(NO_DEPENDS) && !defined(NO_CHECK_DEPENDS) && !exists(${EXTRACT_COOKIE})
-	${_PKG_SILENT}${_PKG_DEBUG}\
-	${ECHO_MSG} "${_PKGSRC_IN}> Validating dependencies for ${PKGNAME}" ; \
-	${MAKE} ${MAKEFLAGS} DEPENDS_TARGET=check-depends ECHO_MSG=${TRUE:Q} IGNORE_FAIL=1 _DEPENDS_TARGET_OVERRIDE=1 install-depends || \
-		{ ${ECHO_MSG} "${_PKGSRC_IN}> ${PKGNAME} cannot build necessary dependencies."; ${FALSE}; }
-.  endif
 .endif

 .if !target(build-depends-list)


Frederick