Subject: Re: Proposed fix for fetch-list recursion
To: None <tech-pkg@netbsd.org>
From: Bernd Ernesti <netbsd@arresum.inka.de>
List: tech-pkg
Date: 02/24/2002 15:09:53
On Sun, Feb 24, 2002 at 02:16:11PM +0100, Bernd Ernesti wrote:
> On Fri, Feb 22, 2002 at 05:59:07AM -0600, Frederick Bruckman wrote:
[..]
> > The entire patch may be viewed at
> > 
> > 	ftp://ftp.netbsd.org/pub/NetBSD/misc/fredb/fetch-list.diff
> > 
> > I'll commit Monday, unless someone raises an objection before then.

Ok, more comments.

It tries to fetch files, where the package Makefile have this:

do-fetch:
        @if ${TEST} \! -f ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX}; then \
                ${ECHO} "===> You need to request a password on ${HOMEPAGE}"; \
                ${ECHO} "     and fetch on your own source file."; \
                exit 1; \
        fi

Thats from audio/simian.

And runing that script produce this:

Requesting http://weewave.mer.utexas.edu/MED_files/CODE_RQST/simian_12_98.tar.gz
  (via 127.0.0.1:3128)
401 Unauthorized
Username for `CLUB': 

Now, you don't get the echo message from the package Makefile.

I guess that would be also a problem for other packages which have such
targets (fetching a distfile manually).

And what about adding the file size to the

# Fetch simian_12_98.tar.gz:
#

lines?

Bernd