Subject: Re: Proposed fix for fetch-list recursion
To: Frederick Bruckman <fredb@immanent.net>
From: Bernd Ernesti <netbsd@arresum.inka.de>
List: tech-pkg
Date: 02/24/2002 14:16:11
On Fri, Feb 22, 2002 at 05:59:07AM -0600, Frederick Bruckman wrote:
> Before I say anything else, observe:
> 
>   fredb@tautology-> pwd
>   /s/pkgsrc/x11/gnome
>   fredb@tautology-> du -sk /tmp/distfiles
>   1       /tmp/distfiles
>   fredb@tautology-> time make fetch-list DISTDIR=/tmp/distfiles | wc
>       1972    5611   68799
>     445.32s real    53.85s user    42.16s system
> 
> Try that on 1.5.2 tagged pkgsrc! The previous time I tried that
> myself, it took several *days*. I calculate that this is therefore an
> improvement on the order of 100,000%! Forget about "make fetch-list"
> at the top level with an old pkgsrc, which now takes, with this
> change, about half an hour on tautology (K6-2 450).
> 
> The entire patch may be viewed at
> 
> 	ftp://ftp.netbsd.org/pub/NetBSD/misc/fredb/fetch-list.diff
> 
> I'll commit Monday, unless someone raises an objection before then.

Hmmm, a few comments:

- you don't see which pkg directory corresponds to fetch:

#
# Fetch files for gtkmserv-0.5.2:
#

That should be changed to something like this:

#
# Fetch files for audio/gtkmserv (gtkmserv-0.5.2):
#

- it is no longer possible to do a make fetch in a pkg directory,
  nor even in a subdir under pkgsrc.

Bernd