On Sun, Sep 09, 2001 at 09:59:46AM +0200, Bernd Ernesti wrote:
> On Sun, Sep 09, 2001 at 06:19:44AM +0300, Johnny C. Lam wrote:
> > 
> > Module Name:	pkgsrc
> > Committed By:	jlam
> > Date:		Sun Sep  9 03:19:43 UTC 2001
> > 
> > Modified Files:
> > 	pkgsrc/graphics/Mesa: buildlink.mk
> > 
> > Log Message:
> > Create an empty xmesa.h file in ${BUILDLINK_DIR}/include if it doesn't
> > already exist.  This file is in Mesa-3.4.2, but not in the Mesa included
> > with XFree86-4.x where the definitions in the file have migrated elsewhere.
> > We create an empty one in this case to prevent compile errors caused by
> > source files including xmesa.h and not finding it.
> 
> from xmesa.h:
> 
> /*
>  * Mesa/X11 interface.  This header file serves as the documentation for
>  * the Mesa/X11 interface functions.
>  *      
>  * Note: this interface isn't intended for user programs.  It's primarily
>  * just for implementing the pseudo-GLX interface.
>  */
> 
> So, which packages tries to include that file?

I think this was discussed a bit on packages@netbsd.org last month regarding
the KDE-1.x packages.  These packages were breaking on the bulk-build
machine (1.5.1/i386 + XF4), and the cause was traced to a missing xmesa.h.

> I don't think that we should do your hack from above, we should better fix the
> package to not include that file, given that you just created an empty one so
> this include files isn't really needed.

It's not needed on XF4, but I'm not sure if it's really not used by packages
that use Mesa.  I tend to be pessimistic about whether 3rd party software
developers pay attention to comments like "Don't do this!" or "Don't use this
file!".  Another developer (I forget who) mentioned that programs usually
compiled when the inclusion of <GL/xmesa.h> was commented out, and proposed
this hack as a possible solution to cover the transition from XF3 to XF4.  I
can easily back this change out, but I'm ambivalent so I'll wait for others
to chime in first.

	Cheers,

	-- Johnny Lam <jlam@jgrind.org>