Subject: Re: pkg/11189: pkg tcl-8.3.2 won't compile on i386 1.4.1
To: David Rankin <email@example.com>
From: Todd Vierling <firstname.lastname@example.org>
Date: 10/10/2000 17:38:55
On Tue, 10 Oct 2000, David Rankin wrote:
: /usr/pkg/bin/libtool --mode=link cc -Wl,-R/usr/pkg/lib tclAppInit.o
: libtcl83.la -lm -lc -Wl,-rpath,/usr/pkg/lib -o tclsh
I'm not sure where the "-Wl,-rpath" is coming from, as patch-aa shows only
the "libtool --mode=link -Wl,-R", which is actually not correct either.
The suggested fix in the PR may be correct; tcl is trying to do its own
handling, and botching it:
: On lines 433 and 437 of the file unix/Makefile.in, remove the
: item @TCL_LD_SEARCH_FLAGS@ . This will prevent the bad -rpath insertion.
If anything, this variable should directly supply "-rpath" or "-R" to
libtool, because libtool is smart enough to figure out what to do with it.
The extra "-Wl,-R" in patch-aa is probably not needed if this is fixed.
* Note to pkg maintainers: You do not need to do --mode= with libtool in
almost every case. It's actually smart enough to figure out the mode based
on "cc" vs. "cc -c" vs. "install" automatically.
-- Todd Vierling <email@example.com> * http://www.wasabisystems.com/
-- Speed, stability, security, and support. Wasabi NetBSD: Run with it.