Subject: Re: rfc: socketing it to gre
To: None <>
From: David Laight <>
List: tech-net
Date: 09/16/2007 00:24:54
On Fri, Sep 14, 2007 at 12:37:57PM -0500, David Young wrote:
> On Wed, Sep 12, 2007 at 11:24:09PM -0700, Darren Reed wrote:
> > David,
> > 
> > Please don't put inline functions in header files, especially using
> > names that are all in capital letters and thus look like macros.
> I don't see any harm in putting inline functions into header files,
> especially not when they will be shared by many C files.

Ok, I'll admit to not having looked at the code in question, but
if these functions are non-trivial inlining them may be a performance
loss.  If trivial a #define will suffice!


David Laight: