Subject: Re: rfc: socketing it to gre
To: None <>
From: Darren Reed <>
List: tech-net
Date: 09/12/2007 23:24:09

Please don't put inline functions in header files, especially using
names that are all in capital letters and thus look like macros.

They're my favourite pet hate in Linux because people actually
put important functionality in them.

Also, as this work brings in a new socket type, I think it would
be better to bring in the socket changes first, independant of the
gre changes.