Subject: Re: new EtherIP driver for 4.0
To: Christos Zoulas <email@example.com>
From: Rui Paulo <firstname.lastname@example.org>
Date: 11/23/2006 04:05:37
On Nov 22, 2006, at 8:02 PM, Christos Zoulas wrote:
> In article <E0100A33-E32E-4729-9521-0D1A3198D918@fnop.net>,
> Rui Paulo <email@example.com> wrote:
>> On Nov 21, 2006, at 8:50 PM, Hans Rosenfeld wrote:
>>> On Tue, Oct 31, 2006 at 03:09:01PM +0000, Rui Paulo wrote:
>>>> I took a very skim look and I couldn't find anything obviously
>>>> There are some KNF nits but nothing important.
>>> After some brainstorming with Rui I made some (mostly cosmetic)
>>> changes to
>>> the code to make it conform to KNF rules. I put the latest
>>> version in
>>> http://headcrashers.org/comp/programs/etherip.tar.gz for others to
>>> another look at it.
>> Anyone has anything to say ? I plan to commit this soon.
> 1. The whole thing needs to be passed through unexpand and possibly
> the indentation in ethersubr.c is wrong.
> 2. s/bzero/memset/
> 3. etherip_ether_aton() -> ether_snprintf(), same as the tap
> Go for it.